Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(static-deploy): add deployment instructions for AWS with Flightcontrol #12067

Closed

Conversation

bahdcoder
Copy link

Description

This PR aims to add instructions for deploying a Vite project to AWS using Flightcontrol.

Flightcontrol provides fully automated deployments to AWS.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.


### Create a Project with Configuration via the Dashboard

1. Create a Flightcontrol project from our Dashboard. Select a repository for the source.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create a Flightcontrol project from our Dashboard. Select a repository for the source.
1. Create a Flightcontrol project from the Dashboard. Select a repository for the source.

3. Add a static site service by clicking the `Add a Static Site`.
4. Add a build command, `yarn build` and select `Single Page App` option.
5. Add any environment variables your project might need.
6. Create your project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Create your project.
6. Submit the new project form.

}
```

4. Create your project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Create your project.
4. Submit the new project form.

@flybayer
Copy link

flybayer commented Mar 9, 2023

for your review @patak-dev

@patak-dev
Copy link
Member

Hey @flybayer, thanks for taking the time to review this one. And @bahdcoder for creating it.
Sorry for the delay, but we are discussing with the team what to do with this page. It isn't scaling well for us to add and keep up-to-date instructions for every service. We believe that is better to start simplifying this page (maybe even delete this section of the guide in the long term). It would scale a lot better and be easier to maintain if each service would include how to use Vite in its own docs. Would it be possible to have a dedicated page for Vite and we could then add a short paragraph here linking to it? I imagine it could be on the examples guides? https://www.flightcontrol.dev/docs/guides/examples

The idea is that if folks would search for "flightcontrol vite", they better reach your own docs and not this section that later on may end up outdated.

@sapphi-red
Copy link
Member

Closing as #13679 is merged

@sapphi-red sapphi-red closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants